Feature/federated credentials #1782
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 25, 2023 19:50
- fix private endpoint in aks
LaurentLesle
requested changes
Aug 28, 2023
There was a problem hiding this comment.
Thanks @najvv for submitting the PR. I have added some comments on the examples you have provided. Can you address them and will continue the review.
examples/compute/kubernetes_services/109-single-cluster-federated-credentials/aks.tfvars
Show resolved
Hide resolved
added 2 commits
August 29, 2023 20:16
|
@LaurentLesle updated examples and included in worklows |
|
Thanks for the PR, we need federated credentials for our gitlab ci/cd integration. |
|
Hello @LaurentLesle, when do you think this could be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue-id
PR Checklist
Description
there is an existing PR #1666 however it does not cover all of use cases. we shall be able to create aks and federated credentials in different landingzones since person who deploy aks may not necessarily have permission to manage ad resources and workload identity shall support both mi and azure app.
Does this introduce a breaking change
Testing
examples are added